ul blog improvements #1522
ul blog improvements #1522
Conversation
✅ Deploy Preview for okta-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| email: email | ||
| }, | ||
| }); | ||
| return res.sendStatus(httpStatus); |
There was a problem hiding this comment.
?? am i missing a paren indention? This looks like you are returning out of the method first, then there's code that will never get hit to check if the user doesn't exist. I don't understand. is the intent for the 404 check to move higher?
| }); | ||
|
|
||
| universalLogoutRoute.use((err,req,res,next) => { | ||
| if(err){ |
There was a problem hiding this comment.
What's an error and why are they all 404?
| @@ -602,7 +668,7 @@ if (!res.ok) | |||
| }} | |||
| ``` | |||
|
|
|||
| The onNewTask function will now look like this: | |||
| The onNewTask function will now look like this with a change made only to the `onNewTAsk` function: | |||
There was a problem hiding this comment.
You should re-evaluate this sentence. It seems repetitive. Also change casing for onNewTAsk
| // Redirect user back to the sign in page | ||
| window.location.href = '/'; | ||
| // Redirect user back to the sign in page | ||
| window.location.href = '/'; |
There was a problem hiding this comment.
out of curiosity, why are using window API here to redirect to home. I thought this is handled already inside the todo app, can't we use React Router?
This blog post has the following features: