Add check of IsValueType to prevent Stack Overflow (#43) #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds to the early out logic at the top of Remove-NullProperties so that when objects like DateTime are passed in it does not loop through child properties until hitting the stack limit
|
Hi @TriggerAu, Can you please provide more details on the issue and how we can reproduce it so we can add a test to verify that the proposed fix solves the problem? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the early out logic at the top of Remove-NullProperties so that when objects like DateTime are passed in it does not loop through child properties until hitting the stack limit
Issue #43 - #43