Update types in DataView #2471
Update types in DataView #2471
Conversation
| cardLayoutOptions.rowActionMenuItems as unknown as ( | ||
| row: MRT_Row<MRT_RowData>, | ||
| ) => any // eslint-disable-line @typescript-eslint/no-explicit-any | ||
| cardLayoutOptions.rowActionMenuItems as CardLayoutProps<MRT_RowData>["rowActionMenuItems"] |
There was a problem hiding this comment.
What's CardLayoutProps that we need an as here? Shouldn't this be TData and not MRT_RowData?
Or even MRT_RowData<TData>?
| (row: TData, index: number, parentRow: MRT_Row<TData>) => { | ||
| if (getRowIdProp) { | ||
| return getRowIdProp(row, index, parentRow); | ||
| } | ||
| if (row.id) { | ||
| return row.id as string; | ||
| } | ||
| return createUniqueId(); | ||
| }, | ||
| [getRowIdProp], | ||
| ) as (row: TData, index: number, parentRow?: MRT_Row<TData>) => string; |
There was a problem hiding this comment.
The as and the function look the same. We shouldn't need those here right? We should know the id is a string at this point I'd guess.
| // type RowOrTableRow<TData extends MRT_RowData> = MRT_Row<TData> | TData | MRT_Row<MRT_RowData>; | ||
| type RowOrTableRow<TData extends MRT_RowData> = MRT_Row<TData> | TData; |
There was a problem hiding this comment.
Did you mean to keep in this commented out line?
| const row = ( | ||
| incomingRow.original ? incomingRow.original : incomingRow | ||
| ) as TData & { id: string }; |
There was a problem hiding this comment.
Interesting. Is this how we're converting row to TData?
| @@ -321,7 +316,7 @@ const TableLayoutContent = <TData extends MRT_RowData>({ | |||
| const hasColumnWithGrow = columns.some((column) => column.grow === true); | |||
|
|
|||
| const dataTable = useMaterialReactTable<TData>({ | |||
| data: (!isEmpty && !isNoResults ? data : []) as TData[], | |||
| data: !isEmpty && !isNoResults ? data : [], | |||
There was a problem hiding this comment.
Interesting. Did we need to remove the as TData[]? Usually you wanna say never[] or any[] to be TData[]:
| data: !isEmpty && !isNoResults ? data : [], | |
| data: !isEmpty && !isNoResults ? data : ([] as TData[]), |
TS can't infer the type of [] without an as unless you add at least one item to it.
I wonder if we can use satisfies instead:
| data: !isEmpty && !isNoResults ? data : [], | |
| data: !isEmpty && !isNoResults ? data : ([] satisfies TData[]), |
We had some types that were incorrect in
DataView; this PR fixes them.