-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use types from pudo's 'typecast' library, PEP8 etc #171
Open
davidread
wants to merge
36
commits into
master
Choose a base branch
from
cleanup-mt2-redux
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably occurred during rebasing.
This line worked in Python 3.5 because of PEP 461: https://www.python.org/dev/peps/pep-0461/ but not in Python 3.4.
+1 I'm so keen to finally get a cleanup of messytables. |
chfw
reviewed
Apr 7, 2017
Can someone push this fix please? |
davidread
force-pushed
the
cleanup-mt2-redux
branch
from
July 5, 2019 20:23
4aa3101
to
126630d
Compare
davidread
changed the title
Consolidated changes: typecast, python 3 support, etc.
Use types from pudo's 'typecast' library, PEP8 etc
Oct 18, 2019
StevenMaude
added a commit
to sensiblecodeio/messytables
that referenced
this pull request
Jul 5, 2020
Non-merged PR: okfn#171
StevenMaude
added a commit
to sensiblecodeio/messytables
that referenced
this pull request
Jul 5, 2020
Non-merged PR: okfn#171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pudo's #155 with fixes from @StevenMaude
Let's see if we can get this merged?