Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create releases within okd-project/okd instead of okd-project/okd-scos #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Prerequisites
1. create or update the following secrets:
* `okd-githubapp-auth`
* contains key `private.key`, which is private key of GitHub App (okd-tekton-token) with permissions to create releases in `okd-scos` project
* contains key `private.key`, which is private key of GitHub App (okd-tekton-token) with permissions to create releases in `okd` project
* `okd-quay-pull-secret`, which is a dockerconfig with permissions to push to `quay.io/okd/scos-release` and `quay.io/okd/scos-content`
* `okd-release-gpg-signing-key`
* contains key `private.key`, which is the GPG key used to sign the OKD release
Expand Down Expand Up @@ -33,7 +33,7 @@ oc create -f environments/moc/pipelineruns/okd-release-next-pipelinerun.yaml
## Annex - running a task individually
```bash
tkn task start create-github-release \
--param github-org-repo="okd-project/okd-scos" \
--param github-org-repo="okd-project/okd" \
--param github-token-secret-key="gh-okd-token" \
--param github-token-secret-name="gh-token" \
--param gpg-key-id="[email protected]" \
Expand Down
4 changes: 2 additions & 2 deletions base/tekton.dev/tasks/docs/get-github-access-token.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ After the creation of the GitHub App, it is possible to install it in the organi
1.1 Install it on okd-project
![](assets/install_1.1.png)

2. Select only the repos where the GitHub App (okd-tekton-token) is needed. In this use case okd-project/okd-scos repo is selected and after that click on <kbd>Install</kbd>
2. Select only the repos where the GitHub App (okd-tekton-token) is needed. In this use case okd-project/okd repo is selected and after that click on <kbd>Install</kbd>
![](assets/install_2.png)


At this point the GitHub App (okd-tekton-token) is installed in the repo **okd-scos**. This GitHub App will be able to deliver token when requested by an external app.
At this point the GitHub App (okd-tekton-token) is installed in the repo **okd**. This GitHub App will be able to deliver token when requested by an external app.

## New Tekton Task
This sections shows the tekton task created to retrieve an access token calling the GitHub App created in the previous steps. Also, it shows the parameters required by this tekton task.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
- name: enable-notifications
value: "true"
- name: github-org-repo
value: okd-project/okd-scos
value: okd-project/okd
- name: is-release-latest
value: "false"
- name: matrix-endpoint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
- name: enable-notifications
value: "true"
- name: github-org-repo
value: okd-project/okd-scos
value: okd-project/okd
- name: is-release-latest
value: "true"
- name: matrix-endpoint
Expand Down