Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added color support #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added color support #7

wants to merge 1 commit into from

Conversation

vwvw
Copy link

@vwvw vwvw commented Jan 28, 2020

Hey,

Thanks for the nice website! I needed the ability to choose the color of my tag and thought I could make you profit from it!

Best

@okalachev
Copy link
Owner

okalachev commented Jan 28, 2020

Hi! Thank you for the contribution!

Actually, I don't get why someone ever needs to paint an aruco marker in different color than black. The marker should be recognizable as well as possible, and the two colors that contrast the most in every lighting condition are obviously black and white.

So what is the rationale of this?

@vwvw
Copy link
Author

vwvw commented Jan 29, 2020

I'm working with the markers outside with some heavy shadows / sunlight. When half the tag is in the shadow, the white in the shadow appear greyer than the black in the sunlight. We decided for color tag and do some thresholding on the Hue value.
Woudl you have done it differently?

@riccardogiorato
Copy link

I would like to have this option too if it's possible to merge it in the master.

@vwvw
Copy link
Author

vwvw commented Jan 29, 2020

In the mean time, you can just fork the PR and launch a simple web server in the directory.

python3 -m http.server

@okalachev
Copy link
Owner

I don't think the main settings is a good place for such an option.

The site title says this is aruco markers generator, and the official aruco documentation states very clearly, what an aruco marker looks like. It's a black-and-white square with pixels inside.

Adding such an option can easily mislead the user and make them believe that a colored marker is a valid aruco marker, while it's not. Moreover, it has white or a whitish colors as valid options, but a white marker is obviously not correct.

If you really find this feature useful, I can consider adding it in a more hidden way, maybe as a GET-parameter or something, for those, who know they actually need this.

@riccardogiorato
Copy link

Hey @okalachev as a GET parameter would be awesome!

@vwvw
Copy link
Author

vwvw commented Feb 3, 2020

Yeah, GET parameter could work too. Do you want it always present, e.g. landing page http://chev.me/arucogen/?color=000000? Or more like a flag ?color=true which would enable for the HTML color picker with HSV options?

@okalachev
Copy link
Owner

Let's hide the additional stuff (color selector) under extra=1 GET-parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants