-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added color support #7
base: master
Are you sure you want to change the base?
Conversation
Hi! Thank you for the contribution! Actually, I don't get why someone ever needs to paint an aruco marker in different color than black. The marker should be recognizable as well as possible, and the two colors that contrast the most in every lighting condition are obviously black and white. So what is the rationale of this? |
I'm working with the markers outside with some heavy shadows / sunlight. When half the tag is in the shadow, the white in the shadow appear greyer than the black in the sunlight. We decided for color tag and do some thresholding on the Hue value. |
I would like to have this option too if it's possible to merge it in the master. |
In the mean time, you can just fork the PR and launch a simple web server in the directory. python3 -m http.server |
I don't think the main settings is a good place for such an option. The site title says this is aruco markers generator, and the official aruco documentation states very clearly, what an aruco marker looks like. It's a black-and-white square with pixels inside. Adding such an option can easily mislead the user and make them believe that a colored marker is a valid aruco marker, while it's not. Moreover, it has white or a whitish colors as valid options, but a white marker is obviously not correct. If you really find this feature useful, I can consider adding it in a more hidden way, maybe as a GET-parameter or something, for those, who know they actually need this. |
Hey @okalachev as a GET parameter would be awesome! |
Yeah, GET parameter could work too. Do you want it always present, e.g. landing page http://chev.me/arucogen/?color=000000? Or more like a flag |
Let's hide the additional stuff (color selector) under |
Hey,
Thanks for the nice website! I needed the ability to choose the color of my tag and thought I could make you profit from it!
Best