Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sql in rails way #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chansuke
Copy link

I've updated the query in rails way.I am using verbose SQL for LEFT JOIN in joins query but you can use left_outer_joins from Rails5.
http://guides.rubyonrails.org/active_record_querying.html#left-outer-joins
http://blog.bigbinary.com/2016/03/24/support-for-left-outer-joins-in-rails-5.html

@chansuke chansuke force-pushed the hotfix/update-sql-in-rails-way branch from b64abf7 to a5239ae Compare June 23, 2017 08:05
@ojde
Copy link
Owner

ojde commented Jun 26, 2017

Nice! Thanks!

Being not very sophisticated it git(hub) yet, what do i have to do now? "Create a merge commit", "Squash and Merge", or "Rebase and Merge"? And, btw, what are the differences?

@chansuke
Copy link
Author

chansuke commented Jun 27, 2017

@ojde Thanks ojde!!If the PR is ok,Create a merge commit is better:)
https://help.github.com/articles/about-pull-request-merges/

  • Create a merge commit ⇒ Merge all of the commits into the base branch
  • Squash and Merge ⇒ Squash the commits into a single commit
  • Rebase and Merge ⇒ All commits from the topic branch (or head branch) are added onto the base branch individually without a merge commit

@ojde
Copy link
Owner

ojde commented Jul 7, 2017

I wrote you an e-mail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants