Port to WASI by adding a check for getrlimit #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the latest clang formatter has changed. I'm happy to merge once those issue are resolved. I can fix those tonight in the develop branch or if you are so inclined feel free to fix in your branch. |
ohler55
approved these changes
May 11, 2024
|
Thank you for fixing the clang formatting warnings. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds WebAssembly/WASI target support for the extension library. Right now, we don't have an easy way to set up CI to test it, but we would appreciate it if we could merge the change into the upstream.
I manually tested it works well on my end.