Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyenv plugin #65

Closed
wants to merge 1 commit into from
Closed

Update pyenv plugin #65

wants to merge 1 commit into from

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Sep 29, 2018

Difference between old and new plugins:
Old plugin doesn't call status --is-interactive; and . (pyenv init -|psub). That means completions are not loaded and PYENV_SHELL is not set. New plugin doesn't call this command either, but it has completions generation script bundled, so completions are generated when pyenv is called. It also sets PYENV_SHELL on init.

Difference between old and new plugins:
Old plugin doesn't call `status --is-interactive; and . (pyenv init
-|psub)`. That means completions are not loaded and PYENV_SHELL is not
set. New plugin doesn't call this command either, but it has completions
generation script bundled, so completions are generated when `pyenv` is
called. It also sets `PYENV_SHELL` on init.
@derekstavis
Copy link
Member

derekstavis commented Oct 8, 2018

cc @scorphus @pantuza

@rominf
Copy link
Contributor Author

rominf commented Nov 29, 2018

Any progress?

@sagebind
Copy link
Member

Our usual policy is to not reassign existing package names to new projects, as this can be surprising to users that use the old plugin. For example, setting up a new machine, imagine the surprise of omf install pyenv installing a different plugin than the one on your old machine.

Perhaps consider porting your improvements to the existing pyenv plugin instead?

@rominf
Copy link
Contributor Author

rominf commented Jan 26, 2019

@sagebind, what's the difference will I port and heavily change the plugin or we replace it?
Anyway, if you want you can replace contents of existing plugin with the new plugin. Probably, it's even better, because the link is prettier.

@scorphus
Copy link
Member

scorphus commented Jan 26, 2019

@rominf, it's great that you brought up this discussion. There's a pull request open for a few months which I'd pretty much like to merge: oh-my-fish/plugin-pyenv#5

@sagebind, I'd be thankful if you could review it 😃

🐟 🐚

@scorphus
Copy link
Member

Closing in favor of aforementioned PR

@scorphus scorphus closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants