Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change seed from i64 to u64 #81

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Change seed from i64 to u64 #81

merged 1 commit into from
Jun 12, 2024

Conversation

ogxd
Copy link
Owner

@ogxd ogxd commented Jun 1, 2024

No description provided.

@ogxd ogxd linked an issue Jun 1, 2024 that may be closed by this pull request
@ogxd
Copy link
Owner Author

ogxd commented Jun 1, 2024

The question now is: Is this a stability breaking change (and we should increase major version) or API change (and we should only increment minor).
Technically speaking, after that change the stability remains unchanged if we consider the seed in its binary form (see the changes on the stability tests only consists in casting i64 seed to u64)

I am tempted to consider this to only be an API change

@ogxd ogxd changed the base branch from main to v4 June 12, 2024 21:18
@ogxd ogxd merged commit f1ba437 into v4 Jun 12, 2024
11 checks passed
@ogxd ogxd self-assigned this Jun 12, 2024
@ogxd ogxd added this to the GxHash 4 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change i64 seed to u64
1 participant