-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panel with blocks navigation and save/load current state #106
base: main
Are you sure you want to change the base?
Conversation
a74a614
to
76d3b39
Compare
@ogkalu2 Thank you for your trust and the great honor of participating in the project =)
p.s. rebased to fresh main branch |
@ogkalu2 When merging a branch with text size and color, 3 lines were lost, or did you remove them? Block font settings buttons are inactive in automatic mode comic.py
main_window.py
|
Not sure what happened there but i've added it back. i didn't delete it. |
|
@ogkalu2 "Saving the state of the app as a Project (#101)" |
76d3b39
to
2cfccd0
Compare
18d1366
to
754c11f
Compare
@ogkalu2 Hi! I improved my import-export, it seems to me that it can be conveniently worked with manually until you make a general save of the project. Maybe take a look? Is it possible to merge this into the project? |
765f3f2
to
5c6f0c7
Compare
@ogkalu2 Thanks for the fix for drawing and deleting rectangles! Now it was possible to load the cleaned image, blocks and easily change them a little. p.s. By the way, I thought, it is possible to add a call of my function save_blocks_state in auto-mode after processing each image. And this will save the whole project, which people ask for =) |
As I reported in the other pull request, I sometimes get rectangles that lose the text thats attached to them, when I do a final control pass on "automatic mode" runs. About twice every comic. If "save state" could be implemented in a way where it would not be "overwritten" automatically. Or if a "save as (with a different filename)" for save state would be possible, that would help me with those cases - as as soon as a rectange loses its attached (auto translated) text, I could reload the state to get it back. Its a work around, but if you could do that on a "per page basis" (can still be one project file), that would be a workable workaround for me loosing text thats attached to rectangles in the quality control pass after an automatic mode run. Currently, as soon as that happens, I have to stop working on the image, and continue with the next one, so I dont loose the auto recognized text on the image. After that the image stays as auto mode saved it, because I have no way of getting the recognized states back into comic-translate currently. Thank you. edit: Actually, if you would allow or create a backup "state" file for the entire project, in the translation folder in the project folder and made that loadable as well, that would probably also save me one click per page. :) As I then just have to note down the pages, where text attached to a rectangle got lost, and then revisit them after finishing the project (by loading on such state file that covers the entire project, not just every page). edit2: If after auto mode runs every page state is auto saved once, and that save is not overwritten (automatically during the quality controll pass I'm doing after auto mode), that would work for me as well, and probably cause the least amounts of click. Because as soon as the issue pops up, I could just reload state for that page. But for that to work an autosave for every page after auto mode ran would have to have occured. If you can implement that - that probably would be the best case scenario for me (aside from having the issue fixed, that rectangles loose attached text, about twice every comic). Thank you! |
Also by default probably save those state files within the translation folder of the project. So you dont run into issues where the state files get loaded for different projects, because the file names were the same. (001.jpg, 002.jpg, and so on.) Or give them a date and time timestamp as a filename (if you group them into one file, per project) by default. Just as a reminder in case you thought about storing them centrally. ;) |
@notimp of course a date and time stamp is added so as not to accidentally overwrite it)
|
492e115
to
83188ff
Compare
@ogkalu2 rebased on current master |
83188ff
to
c3184d4
Compare
c3184d4
to
5929dee
Compare
New panel in manual mode: