prov/efa: Create efa_ep interface #10705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
force-pushed
the
efa_raw_ep
branch
from
a6186c6 to
98e9fc7
Compare
jiaxiyan
reviewed
Jan 16, 2025
shijin-aws
force-pushed
the
efa_raw_ep
branch
from
98e9fc7 to
9d3bf7f
Compare
jiaxiyan
previously approved these changes
Jan 16, 2025
shijin-aws
force-pushed
the
efa_raw_ep
branch
from
9d3bf7f to
d334996
Compare
Migrate dgram/efa_dgram_ep.c to efa_ep.c as a common ep interface for both dgram and rdm ep type. dgram repo now has nothing and is removed. Signed-off-by: Shi Jin <[email protected]>
shijin-aws
force-pushed
the
efa_raw_ep
branch
from
d334996 to
22e941b
Compare
|
bot:aws:retest |
1 similar comment
|
bot:aws:retest |
jiaxiyan
previously approved these changes
Jan 21, 2025
Extend efa ep interface to make it cover all the applied features that efa-rdm ep interface supports today. It also refactors and moves several internal efa_rdm_ep functions to efa_base_ep.c to cover both efa_direct and efa_rdm ep. Signed-off-by: Shi Jin <[email protected]>
Currently, efa_base_ep's default rnr_retry is 3 which only does a few retry in the firmware level for RNR. This is due to the efa_rdm_ep supports libfabric level RNR retry. However, the efa-direct ep doesn't support libfabric level RNR retry. Then we should make it do infinite RNR retry (7), which is also the default behavior of SRD QP. Signed-off-by: Shi Jin <[email protected]>
shijin-aws
force-pushed
the
efa_raw_ep
branch
from
22e941b to
99cf672
Compare
sunkuamzn
approved these changes
Jan 22, 2025
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes
Refactor/changes are backed by corresponding unit tests.