core,prov/efa: Regulate the usage of optnames #10703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
force-pushed
the
setopt_getopt_man
branch
from
d338e7c to
81c5910
Compare
j-xiong
approved these changes
Jan 15, 2025
bwbarrett
approved these changes
Jan 15, 2025
FI_OPT_EFA_USE_DEVICE_RDMA, FI_OPT_EFA_SENDRECV_IN_ORDER_ALIGNED_128_BYTES, and FI_OPT_EFA_WRITE_IN_ORDER_ALIGNED_128_BYTES should only apply to the fi_setopt call as they are used to enforce the endpoint to perform required operations. If they are not set, provider will do the traffic with supported capabilities by default. In that regard, it causes confusions to support these optnames in the getopt calls. Signed-off-by: Shi Jin <[email protected]>
FI_OPT_SHARED_MEMORY_PERMITTED is used to enforce an endpoint to NOT use shm in the data transfer. It should only apply to the fi_setopt call, in the same model of FI_OPT_CUDA_API_PERMITTED. Signed-off-by: Shi Jin <[email protected]>
shijin-aws
force-pushed
the
setopt_getopt_man
branch
from
81c5910 to
ec3911d
Compare
jiaxiyan
approved these changes
Jan 16, 2025
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits to regulate the usage of some optnames for the fi_setopt/fi_getopt calls,
including the EFA specific ones:
FI_OPT_EFA_USE_DEVICE_RDMA, FI_OPT_EFA_SENDRECV_IN_ORDER_ALIGNED_128_BYTES,
and FI_OPT_EFA_WRITE_IN_ORDER_ALIGNED_128_BYTES
and the common one: FI_OPT_SHARED_MEMORY_PERMITTED