prov/cxi: Allow fi_close() to complete without error #10671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified libfabric behavior to ensure that fi_close() calls on an endpoint complete successfully, even if an MCAST tree is still allocated. This change prevents errors in cases where the endpoint is being closed while retaining the MCAST tree. Signed-off-by: Md Bulbul Sharif <[email protected]>
shijin-aws
reviewed
Jan 2, 2025
| !ofi_atomic_get32(&buf_region->use_cnt)); | ||
| if (!(pool->attr.flags & OFI_BUFPOOL_NO_TRACK)) { | ||
| count = ofi_atomic_get32(&buf_region->use_cnt); | ||
| if (count) { |
There was a problem hiding this comment.
If you want to suppress the error, shouldn't you create the buffer pool with OFI_BUFPOOL_NO_TRACK, or manually warn and clean them in your ep close?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified libfabric behavior to ensure that fi_close() calls on an endpoint complete successfully, even if an MCAST tree is still allocated. This change prevents errors in cases where the endpoint is being closed while retaining the MCAST tree.