Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"underscore" as seperator for file names #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

"underscore" as seperator for file names #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,3 +351,8 @@ MigrationBackup/

# Ignore Visual Studio launchSettings (e.g application arguments)
**/Properties/launchSettings.json

# Ignore exported files
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for that

/BruteShark/BruteShark_Network_Map.json
/BruteShark/BruteShark_Network_Nodes_Data.json
/BruteShark/BruteShark_DNS_Mappings.json
10 changes: 4 additions & 6 deletions BruteShark/CommonUi/Exporting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using System;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for those deletions

using System.Collections.Generic;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text;
using System.Text.Json;

namespace CommonUi
Expand Down Expand Up @@ -38,12 +36,12 @@ public static string ExportToFile(string dirPath, string fileName, IEnumerable<o

public static string ExportNetworkMap(string dirPath, HashSet<PcapAnalyzer.NetworkConnection> connections)
{
return ExportToFile(dirPath, "BruteShark Network Map.json", connections);
return ExportToFile(dirPath, "BruteShark_Network_Map.json", connections);
}

public static string ExportNetworkNodesData(string dirPath, List<NetworkNode> networkNodes)
{
return ExportToFile(dirPath, "BruteShark Network Nodes Data.json", networkNodes);
return ExportToFile(dirPath, "BruteShark_Network_Nodes_Data.json", networkNodes);
}

public static string ExportFiles(string dirPath, HashSet<PcapAnalyzer.NetworkFile> networkFiles)
Expand Down Expand Up @@ -79,7 +77,7 @@ public static string ExportVoipCalls(string dirPath, HashSet<VoipCall> voipCalls

public static string ExportDnsMappings(string dirPath, HashSet<PcapAnalyzer.DnsNameMapping> dnsMappings)
{
var filePath = GetUniqueFilePath(Path.Combine(dirPath, "BruteShark DNS Mappings.json"));
var filePath = GetUniqueFilePath(Path.Combine(dirPath, "BruteShark_DNS_Mappings.json"));

File.WriteAllLines(
filePath,
Expand Down