Skip to content

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Aug 4, 2025

Contents (#737)

IMPORTANT: There are 4 breaking changes.

Fixes

  • Update command in dockerfiles to use new octue twined CLI

Refactoring

  • 💥 BREAKING CHANGE: Move Twined-related octue code into twined subpackage
  • 💥 BREAKING CHANGE: Rename OCTUE_SERVICES_TOPIC_NAME to TWINED_SERVICES_TOPIC_NAME
  • 💥 BREAKING CHANGE: Move octue.runner to octue.twined.runner
  • 💥 BREAKING CHANGE: Remove unused folders, isfolder, and isfile utils
  • Merge TwinedEncoder with OctueJSONEncoder
  • Rename scripts

Testing

  • Restructure test directories
  • Remove unused base test method

Upgrade instructions

💥 Move Twined-related `octue` code into `twined` subpackage

Import Twined-related code that was formerly in octue from octue.twined

💥 Rename `OCTUE_SERVICES_TOPIC_NAME` to `TWINED_SERVICES_TOPIC_NAME`

Use the TWINED_SERVICES_TOPIC_NAME envvar instead of OCTUE_SERVICES_TOPIC_NAME and ensure its value ends in octue.twined.services

💥 Move `octue.runner` to `octue.twined.runner`

Use the new import path: from octue.twined.runner import Runner (note that from octue.twined import Runner will not work)

💥 Remove unused `folders`, `isfolder`, and `isfile` utils

Stop using the get_file_name_from_strand, isfolder, and isfile functions

@cortadocodes cortadocodes changed the title Move current Octue SDK code into twined Move current Octue SDK code into twined subpackage Aug 4, 2025
@cortadocodes cortadocodes self-assigned this Aug 4, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 98.43750% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.98%. Comparing base (19ed977) to head (e0f4a2b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
octue/twined/log_handlers.py 95.34% 2 Missing ⚠️
octue/twined/cloud/service_id.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   94.29%   93.98%   -0.31%     
==========================================
  Files          92       97       +5     
  Lines        3836     3858      +22     
==========================================
+ Hits         3617     3626       +9     
- Misses        219      232      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

BREAKING CHANGE: Use the `TWINED_SERVICES_TOPIC_NAME` envvar instead of `OCTUE_SERVICES_TOPIC_NAME` and ensure its value ends in `octue.twined.services`
@cortadocodes cortadocodes merged commit 1b34ab9 into main Aug 5, 2025
5 checks passed
@cortadocodes cortadocodes deleted the move-current-sdk-code-into-twined branch August 5, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants