-
Notifications
You must be signed in to change notification settings - Fork 4
Move current Octue SDK code into twined
subpackage
#737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twined
twined
subpackage
skipci
skipci
BREAKING CHANGE: Stop using the `get_file_name_from_strand` function
BREAKING CHANGE: Stop using the `isfolder` and `isfile` functions
BREAKING CHANGE: Use the new import path: `from octue.twined.runner import Runner` (note that `from octue.twined import Runner` will not work) skipci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 94.29% 93.98% -0.31%
==========================================
Files 92 97 +5
Lines 3836 3858 +22
==========================================
+ Hits 3617 3626 +9
- Misses 219 232 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BREAKING CHANGE: Use the `TWINED_SERVICES_TOPIC_NAME` envvar instead of `OCTUE_SERVICES_TOPIC_NAME` and ensure its value ends in `octue.twined.services`
skipci
skipci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents (#737)
IMPORTANT: There are 4 breaking changes.
Fixes
octue twined
CLIRefactoring
octue
code intotwined
subpackageOCTUE_SERVICES_TOPIC_NAME
toTWINED_SERVICES_TOPIC_NAME
octue.runner
tooctue.twined.runner
folders
,isfolder
, andisfile
utilsTwinedEncoder
withOctueJSONEncoder
Testing
Upgrade instructions
💥 Move Twined-related `octue` code into `twined` subpackage
Import Twined-related code that was formerly in
octue
fromoctue.twined
💥 Rename `OCTUE_SERVICES_TOPIC_NAME` to `TWINED_SERVICES_TOPIC_NAME`
Use the
TWINED_SERVICES_TOPIC_NAME
envvar instead ofOCTUE_SERVICES_TOPIC_NAME
and ensure its value ends inoctue.twined.services
💥 Move `octue.runner` to `octue.twined.runner`
Use the new import path:
from octue.twined.runner import Runner
(note thatfrom octue.twined import Runner
will not work)💥 Remove unused `folders`, `isfolder`, and `isfile` utils
Stop using the
get_file_name_from_strand
,isfolder
, andisfile
functions