Do not warn even if faraday-retry gem is missing #1706
Conversation
It makes little sense to emit a warning saying "to use retry middleware" when the user does not request that. Remove the warning.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
| begin | ||
| require 'faraday/retry' | ||
| rescue LoadError | ||
| Octokit::Warnable.octokit_warn 'To use retry middleware with Faraday v2.0+, install `faraday-retry` gem' |
There was a problem hiding this comment.
This warning is the only thing that would even let you know that this gem does retries. There is nothing in the README about this. This would be better as an explicit option to enable retries.
There was a problem hiding this comment.
So do you suggest disabling retries by default?
There was a problem hiding this comment.
That would be the best way to remove the warning. The retry functionality needs to be better documented.
It makes little sense to emit a warning saying "to use retry middleware" when the user does not request that. Remove the warning.
Resolves #1567
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!