Reverse order of min in FiniteDatetimeRange.intersection
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leamingrad
approved these changes
Jan 30, 2025
In #187 the implementation of FiniteDatetimeRange.intersection was optimised. This introduced a very subtle change in behaviour. Previously when left.end was equal to right.end then the right.end was favoured. In #187 the implementation was (unintentionally) changed to favour left.end. This change reverses that, to again favour right.end. This really shouldn't matter, but it can be signidicant when the TZ of left and right are different. Eventually we'd like to prevent this kind of mixed TZ behaviour (see #192), but in the short term it seems reasonable to make this tiny change to make things consistent again with how they were before.
Peter554
force-pushed
the
change-order-of-dt-range-interesection
branch
from
48ec2c2 to
d49e9e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #187 the implementation of
FiniteDatetimeRange.intersectionwas optimised. This introduced a very subtle change in behaviour. Previously whenleft.endwas equal toright.endthen theright.endwas favoured. In #187 the implementation was (unintentionally) changed to favourleft.end.This change reverses that, to again favour
right.end.This really shouldn't matter, but it can be significant when the TZ of left and right are different. Eventually we'd like to prevent this kind of mixed TZ behaviour (see #192), but in the short term it seems reasonable to make this tiny change to make things consistent again with how they were before and in order to unblock xocto releases / install in Kraken.