Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Publish new provider version #7

Merged
merged 1 commit into from
Sep 19, 2024
Merged

GHA: Publish new provider version #7

merged 1 commit into from
Sep 19, 2024

Conversation

hamishfor
Copy link

New GHA job to publish new versions of the provider in Spacelift

maddocash
maddocash previously approved these changes Sep 17, 2024
Copy link

@maddocash maddocash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me :)

- name: Publish provider
if: startsWith(github.ref, 'refs/tags/')
env:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍷 I've left the vars as separate entries as I dont necessarily want the secrets exposed in other jobs and it feels right to have publish and release as two separate jobs, if publish fails, it might be useful to have the draft in the UI. If not necessary, I could amalgamate the two jobs Publish and Release.

@hamishfor hamishfor force-pushed the pubish-provider branch 9 times, most recently from 1e10654 to 95b8080 Compare September 19, 2024 04:27
@hamishfor hamishfor merged commit d119a4e into main Sep 19, 2024
5 checks passed
@hamishfor hamishfor deleted the pubish-provider branch September 19, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants