Merge pull request #203 from octoenergy/fix-sqlachemy-set-url-query-s…

…tring Fix update_query_string() returns new URL instance
octoenergy · Apr 20, 2023 · 893d9d8 · 893d9d8
2 parents 0b93676 + 3983de9
commit 893d9d8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.2.1] - 2023-04-20
+### Fix
+  - Issue where URL query parameters were not passed correctly to sqlalchemy for db connections.
+
 ## [1.2.0] - 2023-04-06
 ### Added
   - Add support for SQLAlchemy 2.0 by correctly handling `sqlalchemy.engine.url.URL`s, which are now immutable.

diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 from setuptools.command.install import install
 
 
-VERSION = "1.2.0"
+VERSION = "1.2.1"
 
 REPO_ROOT = pathlib.Path(__file__).parent
 

diff --git a/src/tentaclio/clients/sqla_client.py b/src/tentaclio/clients/sqla_client.py
@@ -97,7 +97,7 @@ def _connect(self) -> Connection:
             database=self.database,
         )
         if self.url.query_string:
-            parsed_url.update_query_string(self.url.query_string)
+            parsed_url = parsed_url.update_query_string(self.url.query_string)
         if self.engine is None:
             self.engine = create_engine(
                 parsed_url,