Make user error msgs in PushStyleVar() and its variants more precise#9221
Open
GrayWolf64 wants to merge 1 commit intoocornut:masterfrom
Open
Make user error msgs in PushStyleVar() and its variants more precise#9221GrayWolf64 wants to merge 1 commit intoocornut:masterfrom
PushStyleVar() and its variants more precise#9221GrayWolf64 wants to merge 1 commit intoocornut:masterfrom
Conversation
Owner
|
The 3 messages are the same because it felt it was unnecessary to add extra string data to the code when the messages are so similar. As the error usually leads to an assert you would identify the callstack immediately, don't you think so? |
Author
|
That's true. Thanks for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this can be an improvement compared with previous 4 duplicate error messages.