[API] Split the deprecated url and descr files implementations to their own submodules #6827
+189
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
split-desprecated-files-from-2.0-fields
branch
from
42a0d4c to
295c6c2
Compare
kit-ty-kate
force-pushed
the
split-desprecated-files-from-2.0-fields
branch
from
e22de59 to
295c6c2
Compare
…ir own submodules
kit-ty-kate
force-pushed
the
split-desprecated-files-from-2.0-fields
branch
from
295c6c2 to
681653f
Compare
kit-ty-kate
added
the
PR: QUEUED
rjbou
removed
the
PR: QUEUED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @rjbou regarding #6253, we'd like to keep the format upgrade code around if only as a basis for opam 3.0.
The real issue with
urlanddescris that they are used even when the opam file being parsed is up-to-date. This is documented but we'd like to move forward and stop doing that and require a manual upgrade to read them.However currently the code for
urlanddescrare in their ownURLandDescrsubmodule, which is used for for the deprecated file formats and as a datatype (including the new features). This PR splits these submodules into two of each to separate the legacy part (dealing with the legacy file formats) and the "normal" submodules which still holds the current datatypes.TODO: while doing this change i chose to change the representation of synopsis/description, which probably should be moved to its own PR with its own discussion.