Adapt warning message for ensures not found #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmid
approved these changes
Oct 9, 2023
n-osborne
force-pushed
the
next-state-wrn-msg
branch
from
f6c1a6d to
bfd31ee
Compare
shym
approved these changes
Oct 17, 2023
plugins/qcheck-stm/src/reserr.ml
Outdated
| pf ppf "Skipping %s:@ model@ %s@ %a" f m text | ||
| "is declared as modified by the function but no translatable ensures \ | ||
| clause was found" | ||
| pf ppf "@[Skipping %s:@ model@ %s@ %a@]@ @[%a@]@ @[%s = f (old %s)@]" f m |
There was a problem hiding this comment.
I would suggest something like:
"Skipping %s:@ model@ %s %a@;%a@ x.%s = ..."to make sure it’s clear that the t must appear, not contents by itself, and that the clause doesn’t need to use old.
shym
force-pushed
the
next-state-wrn-msg
branch
from
bfd31ee to
1c56524
Compare
|
I (force-)pushed a proposed reformulation. |
"translatable" was a bit confusing a word (translation was not really the issue). Add some explanation on what the ensures clause should look like.
shym
force-pushed
the
next-state-wrn-msg
branch
from
1c56524 to
8f2ebf0
Compare
|
Thanks. I like the error message better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new warning message when the
next_statecase cannot be computed with the ensures clauses present in the specifications.This is an attempt to answer point 4 in #150