Add documentation and refactor Tmodule #442
Merged
+166
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrjazzybread feel free to comment on the documentation proposed by this PR 😃 |
n-osborne
force-pushed
the
document-tmodule
branch
from
2704570 to
84c9824
Compare
Also remove unused functions from `Tmodule`
n-osborne
force-pushed
the
document-tmodule
branch
from
84c9824 to
d80b577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an interface file for Tmodule, documents the less trivial parts
and remove unused code.
It becomes quite clear that the abstraction provided by Tmodule is not perfect,
but improvement of it is left to a future PR.