Fix bug in creation of fresh type variables #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Maybe it could be an idea to add a test showing it works (so that we don't break it again later). As a side not, the changelog check in the CI seems broken as you didn't add an entry in it but the check passes... |
n-osborne
approved these changes
Jan 16, 2025
|
Done! |
|
Thanks. Merging now. |
n-osborne
added a commit
to n-osborne/gospel
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy Holidays!
I figured out the problem with the bug from #431: when a fresh type
variable is created, it is "logged" into a hash table, using the
ty_of_dtyfunction, that maps it into another type variable with aunique name. However, there was one instance where we were creating
type variables without adding them to the hash table which was causing
problems when we ran the
ty_matchfunction (which I believe existsonly for integrity checking). This PR should fix this issue.