Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Remove CMake legacy code path #1249

Merged
merged 1 commit into from
Sep 3, 2024
Merged

cmake: Remove CMake legacy code path #1249

merged 1 commit into from
Sep 3, 2024

Conversation

tytan652
Copy link
Contributor

@tytan652 tytan652 commented Aug 29, 2024 •
edited
Loading

Description

cmake: Remove CMake legacy code path

Motivation and Context

This path has disappeared on obs-studio master, now it's obs-websocket turn…

How Has This Been Tested?

Tested OS(s):

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested review from PatTheMav and tt2468 August 30, 2024 22:23
RytoEX
RytoEX approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RytoEX RytoEX merged commit e72e80e into obsproject:master Sep 3, 2024
1 check passed
@tytan652 tytan652 deleted the remove_cmake2 branch September 3, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatTheMav PatTheMav PatTheMav approved these changes

@RytoEX RytoEX RytoEX approved these changes

@tt2468 tt2468 Awaiting requested review from tt2468

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tytan652 @RytoEX @PatTheMav