Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requesthandler: Fix releasing hotkeys triggered by name #1228

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

exeldro
Copy link
Contributor

@exeldro exeldro commented May 31, 2024

Description

Fix releasing hotkeys triggered by name

Motivation and Context

Hotkey pairs require the other hotkey to be released before it can be pressed.
It is done for TriggerHotkeyByKeySequence, but not for TriggerHotkeyByName

How Has This Been Tested?

by calling both hotkeys of an hotkey pair with TriggerHotkeyByName
Tested OS(s):
Windows 11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

@tt2468
Copy link
Member

tt2468 commented Jun 6, 2024

(Just a note that I'm merging this without testing, given the official status of support for these requests)

@tt2468 tt2468 merged commit 3b873ce into obsproject:master Jun 6, 2024
1 check passed
@exeldro exeldro deleted the release_hotkey branch June 6, 2024 08:08
@ikifar2012
Copy link

if you don't mind me asking... when can we expect this to be released to the public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants