Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Update library and target names for qrcodegen #1169

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Sep 19, 2023

Description

qrcodegen is identified as such (without the "lib" prefix) and as the target "qrcodegencpp::qrcodegencpp" by the CMake package generated by obs-deps and the finders in obs-studio when using module fallback.

Motivation and Context

Want OBS Studio to build in Debug without issues. This is a follow-up to #1167.

How Has This Been Tested?

Tested OS(s):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

qrcodegen is identified as such (without the "lib" prefix) and as the
target "qrcodegencpp::qrcodegencpp" by the CMake package generated by
obs-deps and the finders in obs-studio when using module fallback.
@RytoEX RytoEX requested a review from PatTheMav September 19, 2023 15:25
@RytoEX RytoEX merged commit f4a3de5 into obsproject:master Sep 19, 2023
1 check passed
@RytoEX RytoEX deleted the fix-qrcodegen-legacy-cmake branch September 19, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants