Skip to content

Commit

Permalink
cmake: Ignore LNK4099 warning
Browse files Browse the repository at this point in the history
Despite building the PDBs for qrcodegencpp debug builds, we do not
currently ship those PDBs, so MSVC emits an LNK4099 warning, which
causes a build failure. It's unlikely that we'll need to debug in linked
dependencies, so we can ignore this warning. Should we decide in the
future to ship PDBs for these dependencies, the warning would no longer
be emitted, and this flag would be superfluous without requiring a
change. For now, let's make sure we can build in Debug.
  • Loading branch information
RytoEX committed Sep 19, 2023
1 parent 0e611f5 commit 2bfa1b4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -168,4 +168,6 @@ if(OS_WINDOWS)
TARGET obs-websocket
APPEND
PROPERTY AUTORCC_OPTIONS --format-version 1)

target_link_options(obs-websocket PRIVATE /IGNORE:4099)
endif()
1 change: 1 addition & 0 deletions cmake/legacy.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ endif()

if(MSVC)
target_compile_options(obs-websocket PRIVATE /wd4267 /wd4996)
target_link_options(obs-websocket PRIVATE "LINKER:/IGNORE:4099")
else()
target_compile_options(
obs-websocket
Expand Down

0 comments on commit 2bfa1b4

Please sign in to comment.