Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-transitions: Fix stinger showing count for update during transition #11512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

exeldro
Copy link
Contributor

@exeldro exeldro commented Nov 12, 2024

Description

Fix stinger showing count for update during transition

Motivation and Context

When a transition is updated while a transition is running the obs_source_remove_active_child was called on an other source than obs_source_add_active_child
the show_refs counter gets to -1, because obs_source_deactivate does only check if it is above 0 for the source it is called on, not for the tree items in hide_tree

How Has This Been Tested?

On windows 11 in combination with move transition having matched items doing a stinger transition

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Nov 12, 2024
@Lain-B
Copy link
Collaborator

Lain-B commented Nov 16, 2024

I think this looks right. The whole active child thing is annoying and really unsafe. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants