Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp-services: Add Enhanced Streaming support for Dolby Millicast #11509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

murillo128
Copy link
Contributor

@murillo128 murillo128 commented Nov 11, 2024

Description

Add Enhanced Streaming support for Dolby Millicast

Motivation and Context

Add Enhanced Streaming support for Dolby Millicast

How Has This Been Tested?

Local Build & CI Build

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod
Copy link
Member

derrod commented Nov 11, 2024

The more info URL 404s.

@murillo128
Copy link
Contributor Author

Yes, the links will be deployed on prod before the next OBS is released, do you need them live before merging?

@derrod
Copy link
Member

derrod commented Nov 11, 2024

Yes, the links will be deployed on prod before the next OBS is released, do you need them live before merging?

The service list is updated independently of OBS itself, so it should be all live before we merge changes to it.

@murillo128
Copy link
Contributor Author

@derrod thanks! I was not aware of it, as we are not then in a hurry, should we close this PR until we have the docs in place then or move to draft?

@derrod
Copy link
Member

derrod commented Nov 11, 2024

You can just mark it as draft until it's ready.

@murillo128 murillo128 marked this pull request as draft November 11, 2024 14:38
@murillo128 murillo128 marked this pull request as ready for review November 11, 2024 15:00
@murillo128
Copy link
Contributor Author

should be ready now

@WizardCM WizardCM added the Services These are modifications to the Service list and are not tied to the release schedule label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Services These are modifications to the Service list and are not tied to the release schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants