UI: Fix What's New increment settings mismatch #11322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InfoIncrement key in the application config everywhere else. This mismatch caused the "What's New" menu entry to stop functioning.
Lain-B
approved these changes
Sep 28, 2024
WizardCM
approved these changes
Sep 28, 2024
RytoEX
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The InfoIncrement key in the application config everywhere else. This mismatch caused the "What's New" menu entry to stop functioning.
Motivation and Context
The recent settings refactor broke this by mismatching the configs.
Found while investigating #11321.
How Has This Been Tested?
Used the "Help" -> "What's New" menu.
Doesn't work without this PR, does with it.
Made sure that in the code base now the app config is used everywhere for this.
Types of changes
Checklist: