-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions to all the plugin category pages. #552
Add descriptions to all the plugin category pages. #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow - awesome stuff.
I've reviewed all the changed files in both Obsidian and PyCharm diff view.
I made a very few comments about outliers.
I've approved the change, as I'm very happy to accept this as it is.
But will wait for you to comment on the comments, to say if you do feel like fixing anything by hand. Totally up to you...
02 - Community Expansions/02.01 Plugins by Category/Plugins for Editing Notes.md
Show resolved
Hide resolved
02 - Community Expansions/02.01 Plugins by Category/Plugins with custom views.md
Show resolved
Hide resolved
02 - Community Expansions/02.01 Plugins by Category/Pane Management plugins.md
Show resolved
Hide resolved
- [[obsidian-youglish-plugin|Youglish Plugin]]: Use YouTube to improve your pronunciation. YouGlish gives you fast, unbiased answers about how words is spoken by real people and in context. | ||
- [[flashcards-obsidian|Flashcards]]: Anki integration | ||
- [[obsidian-to-anki-plugin|Obsidian_to_Anki]]: This is an Anki integration plugin! Designed for efficient bulk exporting. | ||
- [[obsidian-apple-reminders-plugin|Apple Reminders]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. Another one where there was no description in the linked plugin note.
Hi @andynu - all your PR descriptions have been super clear, but this one is outstanding. Thank you ever so much for capturing the code you used to do the transformation. |
Closing and re-opening, to trigger GitHub Actions. |
It's bleating about conflicts in |
This uses descriptions extracted from the plugin pages themselves. This was @claremacrae's excellent idea since it retains any descriptions for plugins that are no longer present in the json feed.
a668e3b
to
b12fbc2
Compare
Thank you. I'm feeling bad about pointing out those 2 trivial lines now, for the time it cost you. Sorry! Are you OK for me to merge this now? |
@claremacrae I just squashed all those changes. |
Excellent idea. |
Thank you. No worries.
All done now. Ready to merge.
…On Tue, Nov 29, 2022 at 5:43 PM Clare Macrae ***@***.***> wrote:
Thank you. I'm feeling bad about pointing out those 2 trivial lines now,
for the time it cost you. Sorry!
Are you OK for me to merge this now?
—
Reply to this email directly, view it on GitHub
<#552 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAONGLU2DAB3H2YORQYR2TWK2BKRANCNFSM6AAAAAASO5PMCE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Edited: All the plugin category pages to add plugin descriptions
This uses descriptions extracted from the plugin pages themselves. This was @claremacrae's excellent idea since it retains any descriptions for plugins that are no longer present in the json feed.
This is intended as a one-time manual content adjustment. It was scripted to produce, but these areas of the category pages appear to be manually curated by humans, not machine generated, so I hesitate to introduce anything that manipulates them. Because of that the code that generates this is very strict and only manipulates lines that appear to be exactly a link to the target plugin page. There are a few examples where descriptions are not present or where the link line has been edited -- these lines have all been left exactly as they were. For example in the discontinued plugins page
Additionally this PR does not add descriptions to the uncategorized plugins page, as that has been automated in the related PR #551
This is another step in the overall progression of encouraging descriptions on all the plugin pages as described in #343
Code
Please forgive that this is not in python. As a throw-away one-time script I did it in the language that I know best. If we end up pursuing some ongoing automation, of course it will be in python. This script is meant to run in the root of the repository.