Add Artificial Information Filter #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishaanj18
force-pushed
the
add_artifical-information_filter
branch
2 times, most recently
from
641e59a to
2a8ba56
Compare
|
I have added the information filter. I think it can be more clean and optimized but for the start I think this is fine. |
|
Can you write some tests too? So that it also gets automatically tested with CI? You can use sorted random data for example that shouldn't have any artificial information and therefore the keepbits shouldn't change and you can manually add some information to that and see whether it's filtered out. |
observingClouds
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Hi @Ishaanj18,
Thanks for this draft PR. Now we can iterate here and make this bullet proof. I made some comments. Have a look at them!
Cheers!
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Ishaanj18
force-pushed
the
add_artifical-information_filter
branch
from
0985152 to
10a08dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.