Add wait options for reliable auto screenshots#10
Add wait options for reliable auto screenshots#10danshapiro wants to merge 2 commits intoobra:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey Dan! Thanks for this PR. Since you opened it, we've gutted and redone how screenshots work in this repo. Would you mind rebasing against the current version of the code and seeing if this is still needed / adapting it to the new approach? Thanks! |
Summary
Problem
Auto screenshots currently fire immediately after each action. In animated dialogs the target is in the DOM but still hidden (opacity/transform), so the captured frame can miss the UI and show the background instead. Observed in Codex CLI: dialogs appeared in extracted HTML but not in the captured image until re-shot after the animation finished.
Proposal
waitAfterActionMs(small default, overridable) applied before auto screenshots.selector+waitForVisibleto wait forstate:"visible"before capture.Testing
Manual: with a short post-action wait, animated dialogs render in captured frames consistently.
Problem identified and PR prepared by Codex CLI (GPT-5).