-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#133): Add MeasuredXsl
And Tweak line-is-absent
Check
#147
base: master
Are you sure you want to change the base?
feat(#133): Add MeasuredXsl
And Tweak line-is-absent
Check
#147
Conversation
@yegor256 Could you have a look, please? |
* XSL that measures the time of transformation. | ||
* @since 0.1 | ||
*/ | ||
public final class MeasuredXsl implements XSL { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo maybe it's better to put it into test/
directory? It's only for tests, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yegor256 I can't place it into test/
directory, since I use in in LintByXsl
class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo let's make it package private then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo let's make this class package-private, since it's not part of external API of this library
In this PR I've:
MeasuredXsl
that can measure time of allxsl
transformations and prints messages into a log:line-is-absent
check:From
ProgramTest#lintsLargeJnaClass(@Mktmp final Path home)
:Before:
After:
Benchmark
Before:
After:
Realted to #133.