Skip LVM filesystem check on LV reduction #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed-by: Jean-Louis Dupond [email protected] Quite an important one. As if the lvreduce fails, the snapshot disk becomes ILLEGAL. |
aesteve-rh
requested changes
May 23, 2024
|
Thank you for you feedback. I have added a parameterized test that tests the reduce function with different LVM versions which runs without any problems! |
|
Great, can you please check for |
|
I am not quite sure what you mean. I've added an extra assert to the |
aesteve-rh
approved these changes
May 23, 2024
|
/ost |
|
No changes, just squashed my commits together. |
|
/ost |
Since LVM v2.03.17 (lvmteam/lvm2@f6f2737), reducing a logical volume (LV) requires the LV to be active due to the default 'checksize' option, which requires an active LV. This results in the following error when attempting to reduce a non-active LV: ---- err=[\' The LV must be active to safely reduce (see --fs options.)\']' ---- To resolve this, we now check if the LVM version is newer than 2.03.17. If so, we bypass the 'checksize' by using the '--fs ignore' option. This approach is viable because the oVirt already handles checksize, making lvreduce redundant. Signed-off-by: Brooklyn Dewolf <[email protected]>
sandrobonazzola
force-pushed
the
fix/OV-28
branch
from
65d70e4
to
98d7f32
Compare
|
Merging based on previous review and approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since LVM v2.03.17 (lvmteam/lvm2@f6f2737), reducing a logical volume (LV) requires the LV to be active due to the default 'checksize' option, which requires an active LV. This results in the following error when attempting to reduce a non-active LV:
err=[\' The LV must be active to safely reduce (see --fs options.)\']' ----To resolve this, we now check if the LVM version is newer than 2.03.17. If so, we bypass the 'checksize' by using the '--fs ignore' option. This approach is viable because oVirt already handles checksize, making lvreduce redundant.