Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: get gluster volume info from any gluster peer #414

Merged
merged 1 commit into from
May 6, 2024

Conversation

aesteve-rh
Copy link
Member

The function _get_gluster_volinfo query the glusterfs volume info the the storage server, this is translated to the gluster client adding the parameter --remote-host which limits the query to one server, so we are converting the storage server as a single point of failure, if it is not available, it can led to cluster outtage. The proposed changed let the cluster cli to use any available gluster peer.

Bug-Url: https://bugzilla.redhat.com/2264175

Signed-off-by: José Enrique Gutiérrez Mazón [email protected]

@aesteve-rh aesteve-rh requested a review from mz-pdm May 2, 2024 08:41
@aesteve-rh aesteve-rh self-assigned this May 2, 2024
@aesteve-rh aesteve-rh requested a review from nirs as a code owner May 2, 2024 08:41
Copy link
Member

@mz-pdm mz-pdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for functionality, I trust the reviews from master.

The typos in code comments can be addressed in master but please separate the commit title from the rest by a blank line to prevent some git clients to present the whole commit message as a heading. And break the excessively long lines in the commit message.

The function _get_gluster_volinfo query the glusterfs volume
info the the storage server, this is translated to the gluster
client adding the parameter --remote-host which limits the
query to one server, so we are converting the storage server as a
single point of failure, if it is not available, it can led to cluster
outtage. The proposed changed let the cluster cli to use any
available gluster peer.

Signed-off-by: José Enrique Gutiérrez Mazón <[email protected]>
Signed-off-by: Albert Esteve <[email protected]>
@aesteve-rh
Copy link
Member Author

As for functionality, I trust the reviews from master.

The typos in code comments can be addressed in master but please separate the commit title from the rest by a blank line to prevent some git clients to present the whole commit message as a heading. And break the excessively long lines in the commit message.

I did not notice the issue with the commit message in the original patch... But at least we can fix it in the backport, true. Just pushed the change. Thanks for checking!

Copy link
Member

@mz-pdm mz-pdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mz-pdm mz-pdm merged commit 79ad157 into oVirt:ovirt-4.5.3.z May 6, 2024
17 checks passed
@aesteve-rh aesteve-rh deleted the backport_get_gluster_fix branch May 6, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants