Introduce ovirt-engine-repositories role #1

KKoukiou · 2017-12-08T10:40:47Z

No description provided.

KKoukiou · 2017-12-08T10:43:22Z

@mwperina @machacekondra Just moved all files from other repo, and added the rpm related scripts (just copied the from vm-infra making changes where necessary)/

KKoukiou · 2017-12-08T10:44:25Z

Also can somebody with appropriate permissions enable the Travis CI for this repository?

machacekondra · 2017-12-08T10:47:45Z

ci build please

machacekondra · 2017-12-08T10:53:59Z

I've setup everything. Also in engine-setup repo. CI will start to work, once this patch is merged:

https://gerrit.ovirt.org/#/c/85203/

KKoukiou · 2017-12-08T10:59:55Z

@machacekondra Super, thanks!

machacekondra · 2017-12-08T12:35:38Z

build.sh

@@ -0,0 +1,53 @@
+#!/bin/bash
+
+VERSION="1.0.0"


VERSION="1.1.0"

machacekondra · 2017-12-08T12:35:47Z

build.sh

+#!/bin/bash
+
+VERSION="1.0.0"
+MILESTONE=


MILESTONE=master

machacekondra · 2017-12-08T12:35:56Z

build.sh

+
+VERSION="1.0.0"
+MILESTONE=
+RPM_RELEASE="1"


RPM_RELEASE="0.1.$MILESTONE.$(date -u +%Y%m%d%H%M%S)"

machacekondra · 2017-12-08T12:36:20Z

build.sh

+   -e "s|@PACKAGE_VERSION@|$PACKAGE_VERSION|g" \
+   < ovirt-ansible-repositories.spec.in > ovirt-ansible-repositories.spec
+
+  git ls-files | tar --files-from /proc/self/fd/0 -czf "$TARBALL" ovirt-ansible-vm-infra.spec


git ls-files | tar --files-from /proc/self/fd/0 -czf "$TARBALL" ovirt-ansible-repositories.spec

machacekondra · 2017-12-08T12:37:43Z

ovirt-ansible-repositories.spec.in

+%global ansible_roles_dir ansible/roles
+
+Name: @PACKAGE_NAME@
+Summary: Ansible role to create virtual machine infrastructure


Summary: Ansible role to setup oVirt/RHV repositories

machacekondra · 2017-12-08T12:38:16Z

ovirt-ansible-repositories.spec.in

+Requires: ansible >= 2.4
+
+%description
+This Ansible role is used to set the repositories required for


s/set/set up/

seems better for me, but I am not sure.

machacekondra · 2017-12-08T12:38:46Z

ovirt-ansible-repositories.spec.in

+This Ansible role is used to set the repositories required for
+oVirt engine or host installation.
+
+%pretrans -p <lua>


You can remove this %pretrans, it was used only for roles which existed in 4.1

machacekondra · 2017-12-08T12:40:09Z

Thanks for contributing automation files 👍

machacekondra · 2017-12-08T12:42:40Z

build.sh

+  ln -f -s $PKG_DATA_DIR_ORIG $ROLENAME_LEGACY 
+
+  cp -pR defaults/ $PKG_DATA_DIR
+  cp -pR library/ $PKG_DATA_DIR


you can remove this line

KKoukiou · 2017-12-11T10:41:11Z

@mwperina @machacekondra Anything else I could change here? If not let's proceed with merging this one because tests for oVirt/ovirt-ansible-engine-setup#1 are depending on this role.

ovirt-infra · 2017-12-11T10:41:13Z

Hello contributor, thanks for submitting a PR for an this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organisation's projects.

Note: You might see multiple messages like this showing up on a single PR, this is due to a known bug in the GitHub trigger plugin on Jenkins, the infra team is working on fixing this via new testing flow in the near future, so we'll be able to post a single message per PR.

ovirt-infra · 2017-12-11T10:42:02Z

Some tests failed

machacekondra · 2017-12-11T10:42:34Z

ci add to whitelist

machacekondra · 2017-12-11T10:42:47Z

ci build please

ovirt-infra · 2017-12-11T10:43:23Z

Some tests failed

ovirt-infra · 2017-12-11T10:43:45Z

Some tests failed

machacekondra · 2017-12-11T10:46:53Z

ci add to whitelist

machacekondra · 2017-12-11T10:47:25Z

ci build please

machacekondra · 2017-12-11T10:57:42Z

@mwperina Do we want to create legacy symlink for newly created roles? Or are we ok with name just oVirt.repositories?

mwperina · 2017-12-11T10:58:52Z

No, new roles (unreleased in oVirt 4.1.z) should have only the new name, ie oVirt.repositories

machacekondra · 2017-12-11T11:00:09Z

ovirt-ansible-repositories.spec.in

+This Ansible role is used to set up the repositories required for
+oVirt engine or host installation.
+
+-- Remove the legacy directory before installing the symlink. This is known issue in RPM:


Please remove lines 22-28

machacekondra · 2017-12-11T11:01:54Z

build.sh

+PKG_DATA_DIR=${PKG_DATA_DIR:-$ROLES_DATAROOT_DIR/$PACKAGE_NAME}
+PKG_DATA_DIR_ORIG=${PKG_DATA_DIR_ORIG:-$PKG_DATA_DIR}
+PKG_DOC_DIR=${PKG_DOC_DIR:-$DOC_DIR/$PACKAGE_NAME}
+ROLENAME_LEGACY="${ROLENAME_LEGACY:-$ROLES_DATAROOT_DIR/ovirt-repositories}"


Please remove this line.

machacekondra · 2017-12-11T11:02:10Z

build.sh

+  mkdir -p $PKG_DOC_DIR
+
+  # Create a symlink, so legacy role name does work:
+  ln -f -s $PKG_DATA_DIR_ORIG $ROLENAME_LEGACY 


Please remove line 43 and 44.

machacekondra · 2017-12-11T11:02:24Z

ovirt-ansible-repositories.spec.in

@@ -0,0 +1,53 @@
+%global rolename repositories
+%global roleprefix oVirt.
+%global roleprefix_legacy ovirt-


Please remove this line.

machacekondra · 2017-12-11T11:02:46Z

ovirt-ansible-repositories.spec.in

+export PKG_DATA_DIR_ORIG=%{_datadir}/%{ansible_roles_dir}/%{roleprefix}%{rolename}
+export PKG_DATA_DIR=%{buildroot}$PKG_DATA_DIR_ORIG
+export PKG_DOC_DIR=%{buildroot}%{_pkgdocdir}
+export ROLENAME_LEGACY=%{buildroot}%{_datadir}/%{ansible_roles_dir}/%{roleprefix_legacy}%{rolename}


Please remove this line.

machacekondra · 2017-12-11T11:02:53Z

ovirt-ansible-repositories.spec.in

+
+%files
+%{_datadir}/%{ansible_roles_dir}/%{roleprefix}%{rolename}
+%{_datadir}/%{ansible_roles_dir}/%{roleprefix_legacy}%{rolename}


Please remove this line.

ifireball · 2017-12-11T11:51:54Z

ci test please

machacekondra · 2017-12-11T12:55:35Z

ci buid please

KKoukiou · 2017-12-11T13:02:53Z

Thanks for quick reviews!

machacekondra mentioned this pull request Dec 8, 2017

ovirt-repositories: installs release RPM package oVirt/ovirt-ansible#118

Closed

mwperina approved these changes Dec 8, 2017

View reviewed changes

machacekondra reviewed Dec 8, 2017

View reviewed changes

KKoukiou force-pushed the initial-commit branch from cbde719 to 670b1cb Compare December 8, 2017 12:56

mwperina approved these changes Dec 11, 2017

View reviewed changes

machacekondra reviewed Dec 11, 2017

View reviewed changes

KKoukiou added 2 commits December 11, 2017 12:27

Introduce ovirt-engine-repositories role

06ab8c3

Replace yamllint with ansible-lint and also run syntax-check in tox

3872fef

KKoukiou force-pushed the initial-commit branch from 670b1cb to 3872fef Compare December 11, 2017 11:27

machacekondra approved these changes Dec 11, 2017

View reviewed changes

machacekondra merged commit 83c8135 into oVirt:master Dec 11, 2017

KKoukiou deleted the initial-commit branch December 11, 2017 13:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce ovirt-engine-repositories role #1

Introduce ovirt-engine-repositories role #1

KKoukiou commented Dec 8, 2017

KKoukiou commented Dec 8, 2017

KKoukiou commented Dec 8, 2017

machacekondra commented Dec 8, 2017

machacekondra commented Dec 8, 2017

KKoukiou commented Dec 8, 2017

machacekondra Dec 8, 2017

machacekondra Dec 8, 2017

machacekondra Dec 8, 2017

machacekondra Dec 8, 2017

machacekondra Dec 8, 2017

machacekondra Dec 8, 2017

machacekondra Dec 8, 2017

machacekondra commented Dec 8, 2017

machacekondra Dec 8, 2017

KKoukiou commented Dec 11, 2017

ovirt-infra commented Dec 11, 2017

ovirt-infra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

ovirt-infra commented Dec 11, 2017

ovirt-infra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

mwperina commented Dec 11, 2017

machacekondra Dec 11, 2017

machacekondra Dec 11, 2017

machacekondra Dec 11, 2017

machacekondra Dec 11, 2017

machacekondra Dec 11, 2017

machacekondra Dec 11, 2017

ifireball commented Dec 11, 2017

machacekondra commented Dec 11, 2017

KKoukiou commented Dec 11, 2017

		@@ -0,0 +1,53 @@
		#!/bin/bash

		VERSION="1.0.0"

Introduce ovirt-engine-repositories role #1

Introduce ovirt-engine-repositories role #1

Conversation

KKoukiou commented Dec 8, 2017

KKoukiou commented Dec 8, 2017

KKoukiou commented Dec 8, 2017

machacekondra commented Dec 8, 2017

machacekondra commented Dec 8, 2017

KKoukiou commented Dec 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

machacekondra commented Dec 8, 2017

Choose a reason for hiding this comment

KKoukiou commented Dec 11, 2017

ovirt-infra commented Dec 11, 2017

ovirt-infra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

ovirt-infra commented Dec 11, 2017

ovirt-infra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

machacekondra commented Dec 11, 2017

mwperina commented Dec 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ifireball commented Dec 11, 2017

machacekondra commented Dec 11, 2017

KKoukiou commented Dec 11, 2017