Modified Ansible Playbook for add_nfs_domain.yml to include NFS mount… #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options add NFS Versions (non-default NFSv3)
… options add NFS Versions (non-default NFSv3) - added FQCN for block
peter-boden
suggested changes
Aug 18, 2025
Member
There was a problem hiding this comment.
Do I understand it correctly from your message here that this PR isn't complete yet?
Some practical tips:
I think you, maybe unintentionally, pushed an older version? See the linting errors (namespace, order)
Try to make the titles of your commit message short and concise, and if you can, prefix them with the "subject" (test:,ci:,...). Don't be shy on the details in the commit body.
Also, you need DCO, i.e. your commits need to be signed. Look into git commit -s
…FS mount options add NFS Versions (non-default NFSv3) - added FQCN for block" This reverts commit e7526e8.
… options add NFS Versions (non-default NFSv3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… options add NFS Versions (non-default NFSv3)