Logging #12
Merged
Logging #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
Gal-Zaidman
reviewed
Jul 19, 2021
Gal-Zaidman
reviewed
Jul 19, 2021
Gal-Zaidman
reviewed
Jul 19, 2021
Gal-Zaidman
reviewed
Jul 19, 2021
Gal-Zaidman
reviewed
Jul 19, 2021
Gal-Zaidman
suggested changes
Jul 19, 2021
There was a problem hiding this comment.
PR looks good, I think that we will probably add more logs as we will refactor the code.
But there is a large part of this PR that is not related to logging, its more of a refactor/bugfix change.
I think we should split this into 2 PRs or at least 2 commits (and not squash merge)
ghost
closed this
ghost
reopened this
|
Thanks @Gal-Zaidman the issues should now be resolved. |
ghost
self-assigned this
I still see that everything is the same |
Gal-Zaidman
approved these changes
Jul 21, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
This PR adds logging to the image upload process via the go-ovirt-client-log library. It is based on #5 .