Back out the counter cache

It caused other issues like in tests, and I'm not sure it was a slam dunk.
o19s · Jan 8, 2025 · fd8f0f8 · fd8f0f8
1 parent 6164b1e
commit fd8f0f8
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 28 deletions.
diff --git a/app/models/book.rb b/app/models/book.rb
@@ -9,7 +9,6 @@
 #  import_job                  :string(255)
 #  name                        :string(255)
 #  populate_job                :string(255)
-#  query_doc_pairs_count       :integer          default(0), not null
 #  show_rank                   :boolean          default(FALSE)
 #  support_implicit_judgements :boolean
 #  created_at                  :datetime         not null
@@ -65,6 +64,16 @@ class Book < ApplicationRecord
 
   # Scopes
   include ForUserScope
+
+  scope :with_counts, -> {
+                        select <<~SQL.squish
+                          books.*,
+                          (
+                            SELECT COUNT(query_doc_pairs.id) FROM query_doc_pairs
+                            WHERE book_id = books.id
+                          ) AS query_doc_pairs_count
+                        SQL
+                      }
 
   private
 

diff --git a/app/models/query_doc_pair.rb b/app/models/query_doc_pair.rb
@@ -25,7 +25,7 @@
 #  fk_rails_...  (book_id => books.id)
 #
 class QueryDocPair < ApplicationRecord
-  belongs_to :book, counter_cache: true
+  belongs_to :book
   has_many :judgements, dependent: :destroy, autosave: true
 
   validates :query_text, presence: true, length: { maximum: 2048 }

diff --git a/db/migrate/20241218173404_add_query_doc_pairs_count_to_books.rb b/db/migrate/20241218173404_add_query_doc_pairs_count_to_books.rb
diff --git a/db/migrate/20241218173819_reset_all_book_cache_counters.rb b/db/migrate/20241218173819_reset_all_book_cache_counters.rb
diff --git a/db/schema.rb b/db/schema.rb
diff --git a/test/fixtures/books.yml b/test/fixtures/books.yml
@@ -7,7 +7,6 @@
 #  import_job                  :string(255)
 #  name                        :string(255)
 #  populate_job                :string(255)
-#  query_doc_pairs_count       :integer          default(0), not null
 #  show_rank                   :boolean          default(FALSE)
 #  support_implicit_judgements :boolean
 #  created_at                  :datetime         not null

diff --git a/test/models/book_test.rb b/test/models/book_test.rb
@@ -9,7 +9,6 @@
 #  import_job                  :string(255)
 #  name                        :string(255)
 #  populate_job                :string(255)
-#  query_doc_pairs_count       :integer          default(0), not null
 #  show_rank                   :boolean          default(FALSE)
 #  support_implicit_judgements :boolean
 #  created_at                  :datetime         not null