Security and zkApps #921
Merged
Security and zkApps #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
5 tasks
shimkiv
reviewed
May 5, 2024
ymekuria
approved these changes
May 9, 2024
| @@ -43,7 +43,7 @@ function knowsPreimage(preimage: Field) { | |||
| } | |||
|
|
|||
| const expectedHash = | |||
| Field(0x1d444102d9e8da6d566467defcc446e8c1c3a3616d059facadbfd674afbc37ecn); | |||
| 0x1d444102d9e8da6d566467defcc446e8c1c3a3616d059facadbfd674afbc37ecn; | |||
There was a problem hiding this comment.
Suggested change
| 0x1d444102d9e8da6d566467defcc446e8c1c3a3616d059facadbfd674afbc37ecn; | |
| '0x1d444102d9e8da6d566467defcc446e8c1c3a3616d059facadbfd674afbc37ecn'; |
There was a problem hiding this comment.
no, bigint literal!
docs/zkapps/secure-zkapps.mdx
Outdated
|
|
||
| ### Creating an insecure contract | ||
|
|
||
| We need to use either `assertCanMint()` or `assertCanBurn()`, but how do we know which one? Well, let's just add a parameter to the method that tells us whether this is a mint or a burn. Then let's call the appropriate method based on that parameter. Github Copilot fills this out nicely for us: |
There was a problem hiding this comment.
"Github Copilot fills this out nicely" - LOL
One ask from Evan |
|
Otherwise, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new section under "Creating zkApps", called "Security and zkApps".
Topics covered:
I didn't get to write a final section on considerations in low-level circuit writing. This is its whole own can of worms and will need some work to present well.
In addition, this adds a small section on the o1js intro page to host our internal audit and future audits of o1js.