Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental admonition #581

Merged
merged 9 commits into from
Sep 6, 2023
Merged

Conversation

MartinMinkov
Copy link
Contributor

@MartinMinkov MartinMinkov commented Sep 6, 2023

Preview:

image

…ding --typescript flag to docusaurus swizzle command for better type safety and autocompletion
…mmon directory to clean up the project structure
…er visual cues

style(Admonition): adjust styles to accommodate new Icon component and improve alignment and spacing
refactor(Admonition): remove redundant .admonitionIcon svg styles, as they are now handled in the parent div
@MartinMinkov MartinMinkov requested a review from a team as a code owner September 6, 2023 20:53
@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 9:18pm

…nded color palette

style(styles.module.scss): change admonitionTip background color from $mina-teal to $mina-lavender for better visual contrast
…special markdown syntax for creating notes, tips, cautions, etc. This will enhance the readability and emphasis of important information in the documentation.
Copy link
Contributor

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -13,3 +13,4 @@ $mina-black: #2d2d2d;
$mina-white: #ffffff;
$mina-error: #e93939;
$mina-purple: #5362c8;
$mina-lavender: #cab2ff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen this color yet. I like it!

@@ -7,7 +7,8 @@
"start": "docusaurus start",
"dev": "ALGOLIA_APP_ID='.' ALGOLIA_SEARCH_API_KEY='.' docusaurus start",
"build": "docusaurus build",
"swizzle": "docusaurus swizzle",
"swizzle": "docusaurus swizzle --typescript",
"swizzle-list": "docusaurus swizzle --list",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice shortcut. Thanks for adding this.

@barriebyron
Copy link
Contributor

great, @MartinMinkov let's do it!

@MartinMinkov MartinMinkov merged commit 84df724 into main Sep 6, 2023
2 checks passed
@MartinMinkov MartinMinkov deleted the feat/experimental-admonition branch September 6, 2023 23:23
@barriebyron
Copy link
Contributor

docs are updated and look great #587

check it out https://docs.minaprotocol.com/zkapps/o1js/recursion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Beta" or "Experimental" tag in documentation, for topics like keccak+ECDSA
3 participants