Fix Tutorial 6 #568
Merged
Fix Tutorial 6 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
….0 to 0.12.1 for compatibility improvements refactor(package.json): rename experimental-zkapp-offchain-storage dependency to experimental-offchain-zkapp-storage and downgrade version from 0.2.0 to 0.1.0 due to package renaming and versioning changes
- refactor: change import paths from 'experimental-zkapp-offchain-storage' to 'experimental-offchain-zkapp-storage' for better naming consistency - refactor: replace 'Field.zero' with 'Field(0)' for better readability - refactor: replace 'assertGt' with 'assertGreaterThan' for better readability - refactor: replace 'setPermissions' with 'account.permissions.set' for better readability - refactor: remove unnecessary 'SignedMessageBoard.test.ts' file - refactor: clean up unnecessary imports and await calls - refactor: update transaction signing and sending process for better readability - refactor: update 'loopUntilAccountExists' and 'makeAndSendTransaction' functions for better readability - refactor: update 'zkAppNeedsInitialization' function for better readability These changes were made to improve the readability and maintainability of the code.
…contract feat(main.ts): add console log message after compiling smart contract for better user feedback
…es, build, and dist directories for better project cleanliness
…ide more project information and improve project visibility on npm
…e transaction validity before sending it
…nks to reflect recent changes feat(experimental-offchain-zkapp-storage): bump version to 0.1.1 to reflect changes in the package
…or better readability
ymekuria
requested changes
Aug 25, 2023
There was a problem hiding this comment.
Nice work @MartinMinkov! Thank you for taking this on!! I left some comments. I cloned the repo and ran the project and UI. I didn't leave comments on the UI because I saw you were going to update it.
examples/zkapps/06-offchain-storage/experimental-zkapp-offchain-storage/README.md
Outdated
Show resolved
Hide resolved
examples/zkapps/06-offchain-storage/experimental-zkapp-offchain-storage/README.md
Outdated
Show resolved
Hide resolved
examples/zkapps/06-offchain-storage/experimental-zkapp-offchain-storage/README.md
Show resolved
Hide resolved
examples/zkapps/06-offchain-storage/experimental-zkapp-offchain-storage/README.md
Outdated
Show resolved
Hide resolved
examples/zkapps/06-offchain-storage/experimental-zkapp-offchain-storage/package.json
Outdated
Show resolved
Hide resolved
barriebyron
reviewed
Aug 28, 2023
examples/zkapps/06-offchain-storage/experimental-zkapp-offchain-storage/README.md
Outdated
Show resolved
Hide resolved
|
thank you @MartinMinkov ! Ongoing editorial content improvements are happening in #557 so I'll want to reconcile all of the goodness here into that work |
MartinMinkov
force-pushed
the
fix/tutorial-6-offchain-storage
branch
from
5416735
to
b7e5444
Compare
…to enable local blockchain usage for testing purposes
…hanges feat(package.json): add clean script to remove build files and database.json for a clean start feat(package.json): add prepublishOnly script to ensure clean build before publishing
…w build command and file path fix(mina-setup.ts): correct the error message to match the updated usage instructions for better user guidance
ymekuria
approved these changes
Aug 30, 2023
examples/zkapps/06-offchain-storage/offchain-storage-zkapp/ui/pages/index.page.tsx
Outdated
Show resolved
Hide resolved
examples/zkapps/06-offchain-storage/offchain-storage-zkapp/ui/pages/index.page.tsx
Outdated
Show resolved
Hide resolved
examples/zkapps/06-offchain-storage/offchain-storage-zkapp/ui/pages/index.page.tsx
Outdated
Show resolved
Hide resolved
barriebyron
added a commit
that referenced
this pull request
Sep 4, 2023
…build artifacts feat(GradientBG.js): add new GradientBG component for dynamic background gradients feat(index.page.tsx): integrate GradientBG component into main page for enhanced UI style(Home.module.css): update styles for better UI/UX and responsive design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the tutorial 6-bitrot. The following changes were made in this PR:
Move the npm package experimental-offchain-zkapp-storage to experimental-zkapp-offchain-storage which is now moved to the docs repo to live beside the tutorial 6. This gives us better maintainability as these projects are now colocated and much easier to find.
Refactor the npm package to be used with the newest version of SnarkyJS. Some other additional refactors to the project were made.
Update the docs content for tutorial 6 to match the newly created npm package
Update the tutorial code (both contracts and UI)
Note
The links in the updated docs are expected to 404, since the new npm package has not been added to the repo yet.