4.0.0 dev gh 237 #289
Merged
4.0.0 dev gh 237 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Co-authored-by: Chris <[email protected]>
Co-authored-by: Chris <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Removed deprecated module
Update copyright
I think there is a bug in the Gregorian initialization because it does account for the hour in the reference epoch. The gregorian initialization and formatter should account for the reference epoch of the time scale.
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
Signed-off-by: Guillaume W. Bres <[email protected]>
… prime offset minus whatever seconds exist in the prime offset
ChristopherRabotin
assigned ChristopherRabotin and gwbres and unassigned ChristopherRabotin
|
@gwbres , I'll be merging this once the tests go through if that's OK. The idea is to get this merged sooner since you've started this work so long ago, and then I have a lot more refactoring I want to make, in addition to fixing a bunch of the bugs that have been reported in the past year. Let me know if that's OK for you. |
This was referenced Apr 23, 2024
|
Closes #237 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening the work on #237 .
@gwbres I was not able to push to your fork of the repo anymore, so I've pushed a new branch. I think you have write access to hifitime, so don't hesitate to work from here.
#280 (comment)