Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Moon ME and Moon PA frames by searching for Euler Parameter datasets in rotations #364

Merged
merged 9 commits into from
Dec 22, 2024

Conversation

ChristopherRabotin
Copy link
Member

Summary

  • Rotations now check Euler parameter datasets for rotation data
  • Fix NAIF FK parsing to correctly account for the RELATIVE_TO keyword

Architectural Changes

No change

New Features

No change

Improvements

  • The latest Meta Almanac now downloads that file.

Bug Fixes

Fix #357 : Prior to this PR, the rotation computation did not look in Euler parameter datasets for the existence of the rotational data.

Testing and validation

  • Exported the Moon PA to J2000 and Moon ME to Moon PA DCMs from SPICE using spiceypy and sxform, ensuring that ANISE returned exactly the same DCM (which it does).
  • Initialize an orbit in the Moon ME frame and transform it to the Earth J2000 frame.

Documentation

This PR does not primarily deal with documentation changes.

@ChristopherRabotin ChristopherRabotin merged commit 3505ba7 into master Dec 22, 2024
18 checks passed
@ChristopherRabotin ChristopherRabotin deleted the fix/gh-357-epa branch December 22, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Euler Parameter Dataset not checked for existence of rotation data
1 participant