This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
fallback to site title if page title is not set for og:title tag #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I was about to submit exactly the same PR haha. |
|
@khalwat Have you seen this? |
|
Yep, I've seen it. I just need to do some local testing before I can safely merge it as a release. I've had a few PRs that ended up causing problems, so I try to be conservative about testing them. |
|
@khalwat Bump! Hehe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to avoid trailing | in og:title / twitter:title tags in page title is empty