Skip to content

Commit

Permalink
Merge branch 'release/1.0.30' into v1
Browse files Browse the repository at this point in the history
  • Loading branch information
khalwat committed Aug 29, 2022
2 parents d9cab6b + 8741ed5 commit 90e0d7b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Plugin Vite Changelog

## 1.0.30 - 2022.08.29
### Fixed
* Move the call to `parent::init()` in `VitePluginService` down to after `useDevServer` is set based on the check for the `VITE_PLUGIN_DEVSERVER` environment variable ([#244](https://github.com/nystudio107/craft-retour/issues/244))

## 1.0.29 - 2022.08.29
### Fixed
* Ensure that `useDevServer` is properly set to `false` even if somehow the incoming request is not a CP request ([#244](https://github.com/nystudio107/craft-retour/issues/244))
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "nystudio107/craft-plugin-vite",
"description": "Plugin Vite is the conduit between Craft CMS plugins and Vite, with manifest.json & HMR support",
"version": "1.0.29",
"version": "1.0.30",
"keywords": [
"craftcms",
"plugin",
Expand Down
2 changes: 1 addition & 1 deletion src/services/VitePluginService.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ class VitePluginService extends ViteService
*/
public function init()
{
parent::init();
// See if the $pluginDevServerEnvVar env var exists, and if not, don't run off of the dev server
$useDevServer = (bool)App::env($this->pluginDevServerEnvVar);
if ($useDevServer === false) {
$this->useDevServer = false;
}
parent::init();
// Only bother if this is a CP request
$request = Craft::$app->getRequest();
if (!$request->getIsCpRequest()) {
Expand Down

0 comments on commit 90e0d7b

Please sign in to comment.