Customizing the shell prompt to display the current Node.js version #3426
+98
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivas365
commented
Sep 16, 2024
srinivas365
commented
- Included functionality for customizing the shell prompt to display the current Node.js version.
adding node version to command prompt
srinivas365
changed the title
ljharb
requested changes
Sep 16, 2024
There was a problem hiding this comment.
In no way is this something the install script should do - modifying the shell prompt is very intrusive, and it would almost certainly break someone’s existing custom prompt.
Also, it doesn’t require nearly this many lines of code to add the node version to the prompt - my shell profile file does it in 2-3 lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.